-
Notifications
You must be signed in to change notification settings - Fork 2.8k
added definition variable container to support EL Resolvers to use th… #4169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
WelschChristopher
wants to merge
3
commits into
flowable:main
Choose a base branch
from
WelschChristopher:added-definition-variable-container
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+516
−113
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
87 changes: 87 additions & 0 deletions
87
...-common/src/main/java/org/flowable/common/engine/impl/el/DefinitionVariableContainer.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,87 @@ | ||
| /* Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.flowable.common.engine.impl.el; | ||
|
|
||
| import java.util.Set; | ||
|
|
||
| import org.flowable.common.engine.api.variable.VariableContainer; | ||
|
|
||
| /** | ||
| * A {@link VariableContainer} that carries definition context (definitionId, definitionKey, deploymentId, scopeType, tenantId) | ||
| * for expression evaluation when no execution is active (e.g. during deployment). | ||
| * This allows EL resolvers to look up the parent deployment and resolve definition-scoped expressions. | ||
| * | ||
| * @author Christopher Welsch | ||
| */ | ||
| public class DefinitionVariableContainer implements VariableContainer { | ||
WelschChristopher marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| protected String definitionId; | ||
| protected String definitionKey; | ||
| protected String deploymentId; | ||
| protected String scopeType; | ||
| protected String tenantId; | ||
|
|
||
| public DefinitionVariableContainer(String definitionId, String definitionKey, String deploymentId, String scopeType, String tenantId) { | ||
| this.definitionId = definitionId; | ||
| this.definitionKey = definitionKey; | ||
| this.deploymentId = deploymentId; | ||
| this.scopeType = scopeType; | ||
| this.tenantId = tenantId; | ||
| } | ||
|
|
||
| public String getDefinitionId() { | ||
| return definitionId; | ||
| } | ||
|
|
||
| public String getDefinitionKey() { | ||
| return definitionKey; | ||
| } | ||
|
|
||
| public String getDeploymentId() { | ||
| return deploymentId; | ||
| } | ||
|
|
||
| public String getScopeType() { | ||
| return scopeType; | ||
| } | ||
|
|
||
| @Override | ||
| public String getTenantId() { | ||
| return tenantId; | ||
| } | ||
|
|
||
| @Override | ||
| public boolean hasVariable(String variableName) { | ||
| return false; | ||
| } | ||
|
|
||
| @Override | ||
| public Object getVariable(String variableName) { | ||
| return null; | ||
| } | ||
|
|
||
| @Override | ||
| public void setVariable(String variableName, Object variableValue) { | ||
|
|
||
| } | ||
|
|
||
| @Override | ||
| public void setTransientVariable(String variableName, Object variableValue) { | ||
|
|
||
| } | ||
|
|
||
| @Override | ||
| public Set<String> getVariableNames() { | ||
| return Set.of(); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.