This repository was archived by the owner on Feb 8, 2022. It is now read-only.
Multiple issues fixed and new features implemented #308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The crash was caused because of the options secondDateAfterFirst which was added in the commit db112c9 The issue was only reproduced when the flag secondDateAfterFirst was set to true and the WheelDayOfMonthPicker view was visible. The listener addOnDateChangedListener was updating the second picker with the minimum date whereas when the WheelDayOfMonthPicker's visibility was gone, the picker had no items resulting in a crash in getItem() method of the WheelPicker adapter.
The crash was caused when today's label was set using todayText() method or from xml. The WheelDayPicker was considering the label from resources for today position instead of the custom set label.
# Conflicts: # singledateandtimepicker/src/main/java/com/github/florent37/singledateandtimepicker/widget/WheelDayPicker.java # singledateandtimepicker/src/main/java/com/github/florent37/singledateandtimepicker/widget/WheelPicker.java
Other florent37#306, florent37#303, florent37#269, florent37#290 The issues were mainly caused because of incorrect retrieving of today item index. Optimized today item index search on scroll.
targetSdkVersion set to API 30 Dependency versions updated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.