control template expects power to be boolean#81
control template expects power to be boolean#81floatplane merged 1 commit intofloatplane:mainfrom sleepybishop:power_template_bool
Conversation
|
thank you for the catch! I'll wait for the checks to finish and then merge |
|
looks like we'll need to rebase this once I get the other PR merged 😄 |
|
pulled in #82 and |
|
sorry for my resposne lag here, I'm on vacation for a couple of days 🏖️. running the checks now |
|
I am trying to fix the check config once and for all in #83, have to step away from the keyboard now while that builds. Thanks for your patience 🙏 |
|
Ok @sleepybishop, main should be in a good state for you to build on. in #83 I cherry-picked your change to update ESPAsyncWebserver, and then got the config for cppcheck and clang-tidy updated to work on all platforms. I think if you rebase this PR on main and only keep dd545fc then it should build fine! Thanks again for your patience 😄 |
|
Sorry for all the trouble my simple change caused you. I've done as you suggested and rebased to only keep the relevant commit. |
|
please don't apologize @sleepybishop! I'm sorry you were the one who stumbled on the hidden brokenness here. thanks for the fix and thanks for your patience! |
Hello, I had trouble with the control page reflecting the correct power status of the unit. It would appear the
powervariable is being sent as a string(ON|OFF)but the template is expecting a boolean. This pr corrects the behavior to be consistent with the output in the metrics template.