feat: make online test team configurable via LINEAR_TEST_TEAM_KEY#110
Closed
lightstrike wants to merge 2 commits intoflipbit03:mainfrom
Closed
feat: make online test team configurable via LINEAR_TEST_TEAM_KEY#110lightstrike wants to merge 2 commits intoflipbit03:mainfrom
lightstrike wants to merge 2 commits intoflipbit03:mainfrom
Conversation
Owner
|
Thanks for putting this together — it's solid work and the helper consolidation is a nice cleanup. However, we've decided to go a different direction on this. Rather than making the team configurable, we want to fix the root cause: tests should not depend on pre-existing teams at all. The See #105 (now closed) for the full rationale, and #117 for the tracking issue. Closing this PR without merging — but thanks again for surfacing the problem and for the effort here! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LINEAR_TEST_TEAM_KEYenvironment variable support to all online test filesteams().first(1)(which picks the first team alphabetically — fragile across workspaces)first(1))test_team_key()helper, reducing duplicationCloses #105
Files changed
crates/lineark-sdk/tests/online.rs— added asynctest_team_id()helper, replaced 8 inline lookupscrates/lineark-sdk/tests/blocking_online.rs— added synctest_team_id_blocking()helper, replaced 3 inline lookupscrates/lineark/tests/online.rs— addedtest_team_key()andtest_team_id_cli()helpers, replaced ~20 inline lookupsTest plan
cargo build --workspacecompiles cleanlycargo clippy --workspace -- -D warningspassescargo fmt --checkpassesLINEAR_TEST_TEAM_KEY=STA(34/34)LINEAR_TEST_TEAM_KEY=STA(11/11)LINEAR_TEST_TEAM_KEY=STA(47/49 — 2 pre-existingProjectCreateUUID collision failures unrelated to this change)first(1)behavior