Skip to content

Conversation

@ndonkoHenri
Copy link

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Introduces a new Cookiecutter template variable (artifact_name) to decouple the on-disk bundle/executable name from the project identifier, while keeping Flutter tooling target names stable.

Changes:

  • Add artifact_name (defaulting to project_name) and use it for produced executable/bundle names on Windows, Linux, and macOS.
  • Update macOS Xcode project/scheme settings and test host paths to match the new on-disk .app and executable name.
  • Clarify template documentation to distinguish project_name (identifier) vs product_name (display) vs artifact_name (on-disk).

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.

Show a summary per file
File Description
{{cookiecutter.out_dir}}/windows/runner/main.cpp Uses product_name for the window title (display name).
{{cookiecutter.out_dir}}/windows/runner/Runner.rc Sets Windows version metadata fields (InternalName, OriginalFilename) to artifact_name.
{{cookiecutter.out_dir}}/windows/runner/CMakeLists.txt Sets OUTPUT_NAME to artifact_name while keeping the CMake target name stable.
{{cookiecutter.out_dir}}/windows/CMakeLists.txt Updates comments to reflect that on-disk naming is handled in runner CMake.
{{cookiecutter.out_dir}}/macos/Runner/Info.plist Adds CFBundleDisplayName using product_name for UI display.
{{cookiecutter.out_dir}}/macos/Runner/Configs/AppInfo.xcconfig Sets PRODUCT_NAME to artifact_name to control on-disk bundle/executable naming.
{{cookiecutter.out_dir}}/macos/Runner.xcodeproj/xcshareddata/xcschemes/Runner.xcscheme Updates BuildableName to artifact_name.app.
{{cookiecutter.out_dir}}/macos/Runner.xcodeproj/project.pbxproj Renames the built product reference and updates TEST_HOST paths to artifact_name.
{{cookiecutter.out_dir}}/linux/CMakeLists.txt Sets target OUTPUT_NAME to artifact_name for the produced executable.
{{cookiecutter.out_dir}}/README.md Documents artifact_name and clarifies variable meanings.
cookiecutter.json Adds artifact_name variable with default value based on project_name.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants