InputCapture support for session persistence by whot · Pull Request #214 · flatpak/libportal

whot · 2026-01-30T05:19:11Z

This is on top of @Jahdal's work from #208

See flatpak/xdg-desktop-portal#1898 for references to other components.

whot · 2026-01-30T05:46:01Z

Note that this is missing a version check, it's not clear yet whether the new features are version 2 or 3 and we'll only need it for the latter case. And even if we don't have it, shoving the options in doesn't hurt so... meh?

edit: merged upstream as version 2 so no version check for 3 is needed

whot · 2026-03-13T02:06:43Z

xdg-desktop-portal has merged support for this so we should be ready to go

sithlord48 · 2026-03-21T12:36:14Z

@jadahl Is there anything holding this up or can we get this landed?

KoljaFrahm · 2026-03-25T16:01:45Z

Also according to the reactions, there are a lot of people waiting that this gets landed (+ a release after)
Can this be merged? :)

whot · 2026-03-26T06:31:15Z

I've had another quick test (hoping it works) but I'm getting valgrind errors, please don't merge this yet.

edit: fix in #217

KoljaFrahm · 2026-03-26T11:25:55Z

Seems like the fix is merged, thank you!

sithlord48 · 2026-03-26T11:29:06Z

Im looking forward to this if only to stop the almost daily AI generated PR's in deskflow to add this.

whot · 2026-03-26T12:19:59Z

There's a little tool to test all this a bit easier now: https://github.com/whot/libportal-clipboard-test

And with #217 fixed valgrind is happy now, so this should be good to go.

jadahl · 2026-04-07T07:50:59Z

+
+  if (call->session->restore_token)
+    g_variant_builder_add (&options, "{sv}", "restore_token",
+                           g_variant_new_string (call->session->restore_token));


Should this do a version check on the portal first? The clipboard one doesn't, but it also is just a request method that may fail, so it's harmless to do without checking the version. Here one would have to avoid setting these for older versions since otherwise the request I assume would fail.

done (as follow-up to make it easier to review), and I added a bunch of test cases too

sithlord48 · 2026-04-14T12:23:34Z

Should the methods names here be considered "final" ?

jadahl · 2026-04-14T12:29:34Z

Should the methods names here be considered "final" ?

You mean they can't be renamed? I'd consider them final once the pull request lands and there is a release; before that things not yet added can be renamed.

sithlord48 · 2026-04-14T12:36:09Z

Should the methods names here be considered "final" ?

You mean they can't be renamed? I'd consider them final once the pull request lands and there is a release; before that things not yet added can be renamed.

After this lands is there a plan for release ?

jadahl · 2026-04-14T12:39:37Z

After this lands is there a plan for release ?

That be a sensible thing to do at least.

This will be necessary when handling signals, which needs to fetch the session from a handle.

This adds API to interact with the clipboard portal associated with a remote desktop session.

This makes the label not "fly away" when some other widget makes its column wider.

Only starts the session and reports the shared devices and streams.

This allows copying to, and pasting from, the clipboard portal.

This makes it easier to construct a session from somewhere else, which will be needed with CreateSession2().

It's its own thing, that also controls the lifetime of the actual session, so need some special casing.

Rather useless, since we're not adding any barriers, but more complete none the less.

In API version 2, the CreateSession() was replaced by CreateSession2()/Start(); add API that corresponds to this. Unfortunately applications will need to check whether this is supported by manually checking the exposed API version, to use the new construction method.

This will allow enabling clipboard integration later.

If the caller hasn't queried the version yet do so before we call into start_session. This is required for correctly sending the restore_token option which we may only send if the version is >= 2.

Our existing tests are derived from dbusmock.DBusTestCase which uses the unittest framework, preventing us from using pytest parameterization. So duplicate the tests for legacy and new approach until that architecture is fixed. And then add a few new tests for session persistence. Co-Authored-by: Claude Code <noreply@anthropic.com>

sithlord48 · 2026-04-20T11:09:29Z

LGTM

KoljaFrahm · 2026-04-22T14:32:51Z

The PR is tested and approved, so can you merge it?
And please do a release after

skewty · 2026-04-28T20:07:04Z

Tagging @smcv (Simon) who was instrumental in last version release. Are we good to go for another release? If not, what is missing / required?

whot marked this pull request as draft January 30, 2026 05:19

whot mentioned this pull request Jan 30, 2026

InputCapture support for session persistence flatpak/xdg-desktop-portal#1898

Merged

nbolton mentioned this pull request Feb 6, 2026

feat: handle input capture session persistence deskflow/deskflow#9415

Draft

whot mentioned this pull request Feb 14, 2026

Inputcapture clipboard integration deskflow/deskflow#9431

Draft

3 tasks

whot force-pushed the wip/inputcapture-persistence branch from 008ccb0 to ccce6f6 Compare February 25, 2026 05:14

whot mentioned this pull request Feb 25, 2026

Add clipboard API and new input capture session construction API #208

Open

whot force-pushed the wip/inputcapture-persistence branch 3 times, most recently from ab7ca0b to e2e7402 Compare February 26, 2026 04:48

whot marked this pull request as ready for review February 26, 2026 04:53

sithlord48 mentioned this pull request Feb 26, 2026

build: check for various libportal features deskflow/deskflow#9526

Closed

sithlord48 mentioned this pull request Mar 20, 2026

Clipboard support in XDG Desktop Portal (Wayland) deskflow/deskflow#8031

Closed

This was referenced Mar 22, 2026

Clipboard support via input capture / remote desktop portal deskflow/deskflow#9600

Open

Persist Input Capture Abilty deskflow/deskflow#9599

Open

whot force-pushed the wip/inputcapture-persistence branch from e2e7402 to ede09b0 Compare March 26, 2026 12:17

jadahl reviewed Apr 7, 2026

View reviewed changes

jadahl added 2 commits April 15, 2026 08:42

portal: Keep track of sessions

25114a7

This will be necessary when handling signals, which needs to fetch the session from a handle.

Add clipboard API

f20146d

This adds API to interact with the clipboard portal associated with a remote desktop session.

jadahl and others added 14 commits April 15, 2026 08:42

portal-test/gtk3: Set screencast label halign to 'start'

cda5d41

This makes the label not "fly away" when some other widget makes its column wider.

portal-test/gtk3: Add remote desktop support

3f81ea9

Only starts the session and reports the shared devices and streams.

portal-test/gtk3: Add clipboard portal knobs

176c0b2

This allows copying to, and pasting from, the clipboard portal.

input-capture: Fold connecting to signals into session constructor

a6521a3

This makes it easier to construct a session from somewhere else, which will be needed with CreateSession2().

portal-test/gtk3: Track input capture session separately

d147d30

It's its own thing, that also controls the lifetime of the actual session, so need some special casing.

portal-test/gtk3: Hook up input capture enable/disable

3fea489

Rather useless, since we're not adding any barriers, but more complete none the less.

portal-test/gtk3: Use split input capture session constructors

4afab9e

This will allow enabling clipboard integration later.

portal-test/gtk3: Enable input capture clipboard integration

d7ec1a7

inputcapture: Add support for persistent sessions

6f1d0a4

inputcapture: Add support for sync CreateSession2

ae82daf

tests: Fix formatting

163c59b

inputcapture: Always query the version before start_session

99e6e2f

If the caller hasn't queried the version yet do so before we call into start_session. This is required for correctly sending the restore_token option which we may only send if the version is >= 2.

whot force-pushed the wip/inputcapture-persistence branch from ede09b0 to e200035 Compare April 15, 2026 03:02

jadahl approved these changes Apr 15, 2026

View reviewed changes

Conversation

whot commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

whot commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

whot commented Mar 13, 2026

Uh oh!

sithlord48 commented Mar 21, 2026

Uh oh!

KoljaFrahm commented Mar 25, 2026

Uh oh!

whot commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

KoljaFrahm commented Mar 26, 2026

Uh oh!

sithlord48 commented Mar 26, 2026

Uh oh!

whot commented Mar 26, 2026

Uh oh!

jadahl Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

whot Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

sithlord48 commented Apr 14, 2026

Uh oh!

jadahl commented Apr 14, 2026

Uh oh!

sithlord48 commented Apr 14, 2026

Uh oh!

jadahl commented Apr 14, 2026

Uh oh!

sithlord48 commented Apr 20, 2026

Uh oh!

KoljaFrahm commented Apr 22, 2026

Uh oh!

skewty commented Apr 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

whot commented Jan 30, 2026 •

edited

Loading

whot commented Jan 30, 2026 •

edited

Loading

whot commented Mar 26, 2026 •

edited

Loading