test(deno): fix incomplete URL substring sanitization#506
Merged
sigmaSd merged 1 commit intoflatpak:masterfrom Feb 23, 2026
Merged
test(deno): fix incomplete URL substring sanitization#506sigmaSd merged 1 commit intoflatpak:masterfrom
sigmaSd merged 1 commit intoflatpak:masterfrom
Conversation
Contributor
Author
|
@sigmaSd Could you please review? |
Collaborator
|
Where do you get these warnings from, is codeql thing something you run manually on this repo ? |
Contributor
Author
This repo is a submodule in my project and submodules are also scanned. |
sigmaSd
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two "security" issues detected by CodeQL in the deno tests. Since they are in tests, it's probably not a big deal.
The fix ensures the strings/urls actually start with the intended strings, instead of only containing them.