You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
LGTM — this is a clean, straightforward fix. All four changes are correct and well-motivated:
Makefile (--all-targets): Adding --all-targets to both lint and fmt targets ensures clippy catches issues in tests, benches, and examples — not just lib/bin targets. The fmt target also correctly gains --workspace which it was previously missing (the lint target already had it).
Benchmark fix (txpool_fetcher.rs): The subscribe_to_txpool_with_blobs signature was updated upstream to require Arc<MempoolTxsDetector> as the third parameter. The benchmark now passes it correctly. No issues.
order_dumper.rs deletion: OrderDumper and OrderStoreAction are not referenced anywhere else in the codebase — confirmed via grep. The comment "Soon to be replaced my mockall" suggests it was already slated for removal. Clean delete.
block_orders/mod.rs: Simply removes the #[cfg(test)] mod order_dumper; declaration to match the file deletion. No other changes to this file.
No bugs, no security concerns, no performance issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
💡 Motivation and Context
✅ I have completed the following steps:
make lintmake test