Removes xFAM and td attributes bit masks#50
Closed
Ruteri wants to merge 1 commit intoflashbots:mainfrom
Closed
Conversation
Collaborator
|
Closed in favor of this PR which includes the logic in #50 but and adds a tested upgrade script + documentation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the xFAM and td attributes bit masks, as they are not needed and in the near future the same functionality can be achieved much cleaner.
What's more, the bit masks for tdAttributes are in reversed order, which means they won't fulfill their purpose.