refactor: introduce PipelineRun aggregate for runner-planner protocol (#904)#905
Merged
Conversation
…#904) Replace the (List<AbstractLoadedStage>, ExecutionResultBuilder) pair carried through the runner with a single mutable aggregate (PipelineRun) that owns in-flight state and produces the ExecuteResponseData. - New `internal.core.pipeline.run`: **PipelineRun**, **StageRun**, **StageState** (polymorphic; Failed carries ErrorInfo). - API change: `ExecutionPlanner.getNextExecution(List<AbstractLoadedStage>)` → `getNextExecution(PipelineRun)`. CommunityExecutionPlanner and CloudExecutionPlanner migrated. - Intent-named mutators: `markStageStarted`, `markStageCompleted(result)`, `markStageFailed(exception)` — aggregate derives ErrorInfo from StageExecutionException. - Removed **ExecutablePipeline** (trivial wrapper) and **ExecutionResultBuilder**; ExecutionPlan holds `List<ExecutableStage>` directly; `PipelineRun.toResponse()` builds the report. No observable behavior change: runner still fail-fasts on StageExecutionException; response shape and event firing points are identical.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the (List, ExecutionResultBuilder) pair carried through the runner
with a single mutable aggregate (PipelineRun) that owns in-flight state and produces the
ExecuteResponseData.
internal.core.pipeline.run: PipelineRun, StageRun, StageState (polymorphic;Failed carries ErrorInfo).
ExecutionPlanner.getNextExecution(List<AbstractLoadedStage>)→getNextExecution(PipelineRun). CommunityExecutionPlanner and CloudExecutionPlanner migrated.markStageStarted,markStageCompleted(result),markStageFailed(exception)— aggregate derives ErrorInfo from StageExecutionException.ExecutionPlan holds
List<ExecutableStage>directly;PipelineRun.toResponse()builds thereport.
No observable behavior change: runner still fail-fasts on StageExecutionException; response
shape and event firing points are identical.