Skip workload check if pid supplied to custom perf#378
Open
jmagnuson wants to merge 1 commit intoflamegraph-rs:mainfrom
Open
Skip workload check if pid supplied to custom perf#378jmagnuson wants to merge 1 commit intoflamegraph-rs:mainfrom
jmagnuson wants to merge 1 commit intoflamegraph-rs:mainfrom
Conversation
Contributor
|
This PR seems to provide a way to run (Sorry for the delay in responding.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of a number of potential solutions for #265, this PR simply adds awareness to custom
perfsupplying a PID set, to avoid the issues I mentioned in the ticket.Related: #95