Fix grammar in project card alt text#568
Conversation
|
I tested this locally. The branch builds, but I think the accessibility improvement should go a bit further before merge. Checks run:
The grammar fix is correct, but the generated page still renders the exact same alt text on all 152 project logos: Also, please remove the generated |
|
Thanks for fixing the typo. One blocker: the PR also updates generated .astro files (.astro/data-store.json, .astro/settings.json, .astro/types.d.ts). Those should be removed so the PR only changes source. While touching this alt text, I would also make it project-specific rather than another generic sentence, for example by using the project name in ProjectCard so screen readers hear the actual logo context. |
eloi-web
left a comment
There was a problem hiding this comment.
I have reviewed all the suggested changes and fixed them.
|
Thanks for updating the alt text to use the project name. That part looks good now. One remaining blocker: the PR still changes the generated
Those files are tracked on the base branch, so the PR should restore them to their original contents rather than delete or update them. After that, the diff should only contain the source change in |
This updates one alt text string for clarity and accessibility.