Fix type error for consumers on @types/react v19#409
Merged
Conversation
React.ReactText was removed from @types/react v19. It was an alias for string | number, so substitute the underlying types directly so the SubMenuProps.title declaration keeps compiling against both v18 and v19.
✅ Deploy Preview for firefox-devtools-react-contextmenu ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
canova
approved these changes
May 28, 2026
Member
canova
left a comment
canova
left a comment
There was a problem hiding this comment.
LGTM, thanks!
For the future reference, it was deprecated here: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/12d3fadfb050819f2a11287e7e3730012b32481e/types/react/v18/index.d.ts#L431-L434
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix is needed to be able to upgrade the profiler to React 19.
React.ReactText was removed from @types/react v19. It was an alias for string | number, so substitute the underlying types directly so the SubMenuProps.title declaration keeps compiling against both v18 and v19.