Skip to content

Upgrade @types/node to match Node 24#6070

Open
fatadel wants to merge 1 commit into
firefox-devtools:mainfrom
fatadel:issue-5956
Open

Upgrade @types/node to match Node 24#6070
fatadel wants to merge 1 commit into
firefox-devtools:mainfrom
fatadel:issue-5956

Conversation

@fatadel
Copy link
Copy Markdown
Contributor

@fatadel fatadel commented May 29, 2026

The Node version was bumped to 24 but @types/node was left at v22, so type definitions no longer matched the runtime. Bump it to the latest v24 release.

Closes #5956

The Node version was bumped to 24 but @types/node was left at v22, so
type definitions no longer matched the runtime. Bump it to the latest
v24 release.

Closes firefox-devtools#5956
@fatadel fatadel requested a review from canova as a code owner May 29, 2026 15:20
@fatadel fatadel requested a review from mstange May 29, 2026 15:20
@codecov
Copy link
Copy Markdown

codecov Bot commented May 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.77%. Comparing base (52f65d8) to head (c632543).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6070      +/-   ##
==========================================
- Coverage   83.77%   83.77%   -0.01%     
==========================================
  Files         329      329              
  Lines       34559    34560       +1     
  Branches     9574     9669      +95     
==========================================
  Hits        28952    28952              
- Misses       5178     5179       +1     
  Partials      429      429              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@canova canova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I think we can also deduplicate these @types/node@* ones with npx yarn-deduplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade @​types/node

2 participants