Switch profiler-edit from minimist to commander#6065
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6065 +/- ##
=======================================
Coverage 83.77% 83.78%
=======================================
Files 329 329
Lines 34547 34544 -3
Branches 9667 9675 +8
=======================================
- Hits 28943 28941 -2
+ Misses 5175 5174 -1
Partials 429 429 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
canova
approved these changes
May 28, 2026
| process.exit(1); | ||
| }); | ||
| } catch (err) { | ||
| console.error(err instanceof Error ? err.message : String(err)); |
Member
There was a problem hiding this comment.
Nit: I think due to exitOverride() above, now the errors are being printed twice, one by commander and the second time here.
For example I tested this:
$ node node-tools-dist/profiler-edit.js --asdfsdf
error: unknown option '--asdfsdf'
error: unknown option '--asdfsdf'
Could we maybe add an early return like this?
if (err instanceof CommanderError) {
// Commander already wrote its own output and chose the
// appropriate exit code.
process.exit(err.exitCode);
}275c0a1 to
79e63d3
Compare
79e63d3 to
08c584a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.