Properly type the return value of _languageExtForPath#5937
Merged
canova merged 2 commits intofirefox-devtools:mainfrom Apr 7, 2026
Merged
Properly type the return value of _languageExtForPath#5937canova merged 2 commits intofirefox-devtools:mainfrom
canova merged 2 commits intofirefox-devtools:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5937 +/- ##
=======================================
Coverage 85.45% 85.45%
=======================================
Files 321 321
Lines 32139 32139
Branches 8850 8850
=======================================
Hits 27463 27463
Misses 4241 4241
Partials 435 435 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mstange
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently this was made this way since the typescript migration. I don't see a reason to keep it this way. Typing it works well.