Fallback to javascript highlighting in the source view as a backup#5936
Open
canova wants to merge 1 commit intofirefox-devtools:mainfrom
Open
Fallback to javascript highlighting in the source view as a backup#5936canova wants to merge 1 commit intofirefox-devtools:mainfrom
canova wants to merge 1 commit intofirefox-devtools:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5936 +/- ##
=======================================
Coverage 85.45% 85.45%
=======================================
Files 321 321
Lines 32139 32139
Branches 8850 8764 -86
=======================================
Hits 27463 27463
Misses 4241 4241
Partials 435 435 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This might be a bit controversial as we are now falling abck to javascript highlighting for all the unkown sources. But I feel like it's an okay compomise. The main issue is that inline scripts share the page URL as the file name, and this doesn't include the
.jsextension, so it's impossible to know if they are indeed JS from the file path. Falling back to javascript for all unkown can have false positives for unkown file types, but I think that's fine.STR: