Skip to content

Fix extractGeckoLogs for structured Log marker format (bug 2022540)#5927

Open
padenot wants to merge 1 commit intofirefox-devtools:mainfrom
padenot:fix-extract-gecko-logs
Open

Fix extractGeckoLogs for structured Log marker format (bug 2022540)#5927
padenot wants to merge 1 commit intofirefox-devtools:mainfrom
padenot:fix-extract-gecko-logs

Conversation

@padenot
Copy link
Copy Markdown
Contributor

@padenot padenot commented Apr 1, 2026

Bug 2022540 switched Log markers from {module, name} fields to structured {level, message} fields, with the module name stored as the marker name. The old format used a single module string that could include the log level prefix (e.g. D/cubeb); the new format uses an integer level field.

Profiles use one format exclusively, never a mix. We detect which by checking the first Log marker found in each thread. This also types things a little more.

Bug 2022540 switched Log markers from {module, name} fields to structured
{level, message} fields, with the module name stored as the marker name.
The old format used a single module string that could include the log level
prefix (e.g. D/cubeb); the new format uses an integer level field.

Profiles use one format exclusively, never a mix. We detect which by
checking the first Log marker found in each thread.
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

❌ Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.41%. Comparing base (96eaf5b) to head (534b9cb).
⚠️ Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
src/utils/window-console.ts 87.50% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5927      +/-   ##
==========================================
- Coverage   85.41%   85.41%   -0.01%     
==========================================
  Files         321      321              
  Lines       32157    32160       +3     
  Branches     8781     8867      +86     
==========================================
+ Hits        27468    27469       +1     
- Misses       4253     4255       +2     
  Partials      436      436              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant