Fix crash when nativeSymbol index is out of bounds in assembly view#5850
Open
fatadel wants to merge 3 commits intofirefox-devtools:mainfrom
Open
Fix crash when nativeSymbol index is out of bounds in assembly view#5850fatadel wants to merge 3 commits intofirefox-devtools:mainfrom
fatadel wants to merge 3 commits intofirefox-devtools:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5850 +/- ##
=======================================
Coverage 85.56% 85.56%
=======================================
Files 319 319
Lines 31420 31424 +4
Branches 8661 8665 +4
=======================================
+ Hits 26885 26889 +4
Misses 4104 4104
Partials 431 431 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Could we instead make it so that |
Contributor
Author
|
Done ✅ Good feedback, thank you @mstange! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5819.
The root cause is at this line.
nativeSymbols[currentNativeSymbol]will yieldundefinedwhen nativeSymbols is empty (eg, frame does not have native symbols). And this is exactly the case because we setinitialNativeSymbol: 0.Fixed by returning null instead of undefined, which is handled fine in the downstream code.
Use the same instructions as in the original issue on this profile to see the issue gone.