Skip to content

fix foreground color of the button on error page#5849

Merged
fatadel merged 1 commit intofirefox-devtools:mainfrom
fatadel:fix-error-page-button-color-5844
Feb 18, 2026
Merged

fix foreground color of the button on error page#5849
fatadel merged 1 commit intofirefox-devtools:mainfrom
fatadel:fix-error-page-button-color-5844

Conversation

@fatadel
Copy link
Contributor

@fatadel fatadel commented Feb 18, 2026

Closes #5844.

Before

Screenshot 2026-02-18 at 14 04 23 Screenshot 2026-02-18 at 14 04 28

Profile

After

Screenshot 2026-02-18 at 13 55 13 Screenshot 2026-02-18 at 13 55 53

Profile

Notes

I've made it look the same way as it used to look before it got broken in this PR. This is how it looked before that PR:

Screenshot 2026-02-18 at 13 41 00 Screenshot 2026-02-18 at 13 41 07

However, I am not sure if this even looks nice.

Use these instructions to hit an error and see the page live.

@fatadel fatadel requested review from canova and mstange February 18, 2026 13:09
@codecov
Copy link

codecov bot commented Feb 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.56%. Comparing base (37b31b0) to head (0246438).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5849   +/-   ##
=======================================
  Coverage   85.56%   85.56%           
=======================================
  Files         319      319           
  Lines       31420    31420           
  Branches     8661     8663    +2     
=======================================
  Hits        26885    26885           
  Misses       4104     4104           
  Partials      431      431           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fatadel fatadel merged commit c71215a into firefox-devtools:main Feb 18, 2026
21 checks passed
@fatadel fatadel deleted the fix-error-page-button-color-5844 branch February 18, 2026 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect button text color on the error page

2 participants

Comments