Skip to content

Conversation

@mstange
Copy link
Contributor

@mstange mstange commented Jan 6, 2026

With this and #5746 combined, yarn build-symbolicator-cli will only produce a single output file. Without this PR, it also produced two SVG files.

@mstange mstange requested a review from canova January 6, 2026 10:39
@mstange mstange self-assigned this Jan 6, 2026
@codecov
Copy link

codecov bot commented Jan 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.67%. Comparing base (3f43d12) to head (0dd124f).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5747   +/-   ##
=======================================
  Coverage   85.67%   85.67%           
=======================================
  Files         314      315    +1     
  Lines       31106    31110    +4     
  Branches     8558     8472   -86     
=======================================
+ Hits        26649    26654    +5     
+ Misses       4027     4026    -1     
  Partials      430      430           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@canova canova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mstange mstange force-pushed the pageselector-favicon-fallback branch from a0ed84c to 0dd124f Compare January 9, 2026 16:27
@mstange mstange merged commit c70f208 into firefox-devtools:main Jan 9, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants