Skip to content

Conversation

@mstange
Copy link
Contributor

@mstange mstange commented Jan 30, 2025

If a JS function is JIT compiled multiple times, then it's currently impossible to see the assembly code for each compilation. If you double-click the call node for the function, the assembly view shows an arbitrary compilation. It doesn't even try to find the one with the highest sample count.

This PR makes it so that the compilation with the highest sample count is chosen, and allows navigating between the different compilations.

@mstange mstange force-pushed the assembly-view-prev-next branch from 49d95a4 to 139d000 Compare January 31, 2025 05:06
@mstange mstange force-pushed the assembly-view-prev-next branch from 139d000 to 74b06df Compare February 14, 2025 04:16
@mstange mstange force-pushed the assembly-view-prev-next branch from 74b06df to 39b83d2 Compare February 24, 2025 00:23
@mstange mstange force-pushed the assembly-view-prev-next branch from 39b83d2 to 7ea21d4 Compare July 10, 2025 17:55
@mstange mstange force-pushed the assembly-view-prev-next branch from 7ea21d4 to 4112ac4 Compare January 8, 2026 09:12
@codecov
Copy link

codecov bot commented Jan 8, 2026

Codecov Report

❌ Patch coverage is 80.95238% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.62%. Comparing base (1a808fe) to head (4112ac4).
⚠️ Report is 37 commits behind head on main.

Files with missing lines Patch % Lines
...mponents/app/AssemblyViewNativeSymbolNavigator.tsx 42.10% 11 Missing ⚠️
src/actions/profile-view.ts 76.19% 5 Missing ⚠️
src/profile-logic/profile-data.ts 95.00% 2 Missing ⚠️
src/reducers/url-state.ts 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5349      +/-   ##
==========================================
- Coverage   85.64%   85.62%   -0.03%     
==========================================
  Files         313      314       +1     
  Lines       31013    31100      +87     
  Branches     8535     8480      -55     
==========================================
+ Hits        26562    26629      +67     
- Misses       4021     4041      +20     
  Partials      430      430              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant