TSFC: avoid setup of unused domains #4829
Open
+26
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbrubeck
force-pushed
the
pbrubeck/fix/integral_type_map
branch
5 times, most recently
from
4d265ea to
4bb8288
Compare
pbrubeck
changed the title
connorjward
previously approved these changes
Jan 21, 2026
| # so corresponding gem expression will never be needed. | ||
| expression = None | ||
| elif integral_type.startswith("interior_facet"): | ||
| return None |
Contributor
There was a problem hiding this comment.
I think that here is another case of using Nones inappropriately, but that's not relevant here.
pbrubeck
commented
Jan 21, 2026
| dx1 = Measure("dx", mesh1) | ||
| dx2 = Measure("dx", mesh2) | ||
| ds1_ds2 = Measure("ds", mesh1, intersect_measures=(Measure("ds", mesh2),)) | ||
| ds1_ds2 = Measure("ds", mesh1, intersect_measures=(Measure("ds", mesh2), Measure("dx", mesh12))) |
Contributor
Author
There was a problem hiding this comment.
We are hitting an error for Forms involving legal integrals on codim 1 multidomain problems. We are able to assemble each term individually. However, the interface mesh must be included in every surface Measure if assembling all integrals all at once.
pbrubeck
force-pushed
the
pbrubeck/fix/integral_type_map
branch
from
9f26aab to
c85d2b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A multi-domain Form is split into single-domain terms. Each term knows that it belongs to a multidomain problem, but is assembled individually. During the assembly of each single-domain term, we may skip the setup on the all the other domains.
firedrake/tsfc/driver.py
Lines 170 to 175 in 4a5cba1
These methods will now skip a mesh not found in
integral_data.domain_integral_type_map(as returned byufl.algorithms.compute_form_data).This is to remove the
integral_type = Noneentries that were hacked into thedomain_integral_type_map, which lead to obscure errors for illegal forms.