overload BrokenElement.__new__ to nest Broken-ness below Vector/Tensor/Mixed-ness#201
Merged
JHopeCollins merged 3 commits intomainfrom Dec 11, 2025
Merged
Conversation
This was referenced Dec 9, 2025
pbrubeck
reviewed
Dec 10, 2025
pbrubeck
reviewed
Dec 10, 2025
Co-authored-by: Pablo Brubeck <brubeck@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is in response to this comment in a Firedrake PR: firedrakeproject/firedrake#4716 (comment)
MixedElement(and theVectorandTensorderived classes) must be at the very outside of an element specification.This means that currently
BrokenElement(MixedElement(...))doesn't work properly.This PR intercepts the
BrokenElement.__new__so that:and similarly for
VectorElementandTensorElement.