net: helpers for fd_xdp_ring_t #7658
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akhinvasara-jumptrading
force-pushed
the
akhin/tx_ready_fix
branch
from
d4580e9 to
b7a3fde
Compare
akhinvasara-jumptrading
changed the title
ripatel-fd
reviewed
Jan 5, 2026
|
|
||
| uint fill_prod = fill_ring->cached_prod; | ||
| uint fill_mask = (fill_ring->depth)-1U; | ||
| ulong frame_mask = FD_NET_MTU - 1UL; |
Contributor
There was a problem hiding this comment.
Can you add a static assertion checking that FD_NET_MTU is a power of 2?
ripatel-fd
approved these changes
Jan 5, 2026
ripatel-fd
reviewed
Jan 5, 2026
ripatel-fd
previously approved these changes
Jan 6, 2026
Contributor
ripatel-fd
left a comment
ripatel-fd
left a comment
There was a problem hiding this comment.
I think the fd_xsk.h API is a bit much, I would have just done the comparisons in line. But looks extensively tested, so I'm happy with it
akhinvasara-jumptrading
force-pushed
the
akhin/tx_ready_fix
branch
from
b7a3fde to
ccf08c2
Compare
Prompted by a bug reported by @colinlyguo
akhinvasara-jumptrading
force-pushed
the
akhin/tx_ready_fix
branch
from
ccf08c2 to
57890af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR factors out the cached fseq logic into fd_xdp_ring_{empty,full} for use in the xdp tile. It adds extensive unit tests for those helpers, and for net_tx_ready (which was slightly refactored for cleaner testing).
This PR also fixes the logic inversion bug reported in https://github.com/firedancer-io/auditor-internal/issues/360.