Skip to content

Comments

feat(js): add longRunning to supports and fix missing part exports#4816

Open
MichaelDoyle wants to merge 1 commit intomainfrom
feat-js-model-types
Open

feat(js): add longRunning to supports and fix missing part exports#4816
MichaelDoyle wants to merge 1 commit intomainfrom
feat-js-model-types

Conversation

@MichaelDoyle
Copy link
Member

Since "longRunning" was missing in TS, it caused some conflicts/mismatches between Go and Python when updating tools common and generating the schemas.

I think this is all that's required. But if not, let me know.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @MichaelDoyle, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on enhancing the TypeScript schema definitions and exports for AI model capabilities and content parts. It addresses inconsistencies that led to schema generation conflicts between different language environments and ensures that all relevant part types are properly exposed for use.

Highlights

  • Schema Alignment: The longRunning property has been added to the ModelInfoSchema in TypeScript, resolving schema generation conflicts between Go and Python.
  • Missing Exports: Several *PartSchema and their corresponding types (e.g., MultipartToolResponseSchema, ReasoningPartSchema) were added to the exports in model.ts.
  • Type Definition Correction: The type definitions for TextPart and ReasoningPart were corrected in parts.ts to accurately reflect their respective schemas.
  • Type Assertion Removal: Unnecessary as ModelInfo type assertions were removed from veo.ts files in Google GenAI plugins, as the longRunning property is now correctly defined in the schema.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • js/ai/src/model-types.ts
    • Added the longRunning boolean property to the supports object within the ModelInfoSchema.
  • js/ai/src/model.ts
    • Exported MultipartToolResponseSchema, ReasoningPartSchema, ResourcePartSchema, and their corresponding types (MultipartToolResponse, ReasoningPart, ResourcePart).
  • js/ai/src/parts.ts
    • Moved the TextPart type definition to immediately follow TextPartSchema.
    • Corrected the ReasoningPart type definition to correctly infer from ReasoningPartSchema.
  • js/plugins/google-genai/src/googleai/veo.ts
    • Removed the as ModelInfo type assertion from the info object in commonRef.
  • js/plugins/google-genai/src/vertexai/veo.ts
    • Removed the as ModelInfo type assertion from the info object in commonRef.
Activity
  • No human activity has occurred on this pull request since its creation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the longRunning property to the ModelInfoSchema to indicate if a model supports long-running operations. This change allows for the removal of type casting in the veo.ts files for Google AI and Vertex AI plugins. Additionally, the PR addresses missing exports for various Part schemas and types in model.ts, and corrects a definition error for ReasoningPart in parts.ts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant