-
Notifications
You must be signed in to change notification settings - Fork 657
feat: Add AIM telemetry support and test it in xai sample #4386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @zarinn3pal, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the GCP telemetry integration by introducing a new Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a significant and well-executed refactoring of the Google Cloud telemetry implementation. The new GcpTelemetry class effectively encapsulates the configuration and lifecycle management of tracing, metrics, and logging, which greatly improves code organization and maintainability. The changes also include important fixes for compatibility with Google Cloud services, such as adjusting span end times for Cloud Trace and forcing DELTA temporality for Cloud Monitoring. The addition of telemetry to the xai-hello sample is a valuable way to demonstrate and test this new functionality. I've included a couple of suggestions for minor improvements to further enhance the code quality.
| getattr(p, '__name__', '') == '_inject_trace_context' and getattr(p, '__self__', None) == self | ||
| for p in processors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The deduplication logic for the structlog processor is flawed. The check for _inject_trace_context will not match the function being added, which is named inject_trace_context. This will cause the check to always fail, leading to duplicate processors being added if initialize() is called multiple times. Additionally, the getattr(p, '__self__', None) == self check is not suitable for closures as they don't have a __self__ attribute. A simpler check on the correct function name would be more effective and robust.
| getattr(p, '__name__', '') == '_inject_trace_context' and getattr(p, '__self__', None) == self | |
| for p in processors | |
| getattr(p, '__name__', '') == 'inject_trace_context' for p in processors |
| self._log_input_and_output = log_input_and_output | ||
| self._project_id = project_id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.



This PR adds a fix to AIM telemetry implementation . Both traces and metrics are logged and can be seen on the dashboard. Xai sample is modified to showcase the implementation