Skip to content

fix(firestore, web): update Timestamp handling in jsify and EncodeUtility#18264

Merged
SelaseKay merged 6 commits into
mainfrom
firestore_18233
May 11, 2026
Merged

fix(firestore, web): update Timestamp handling in jsify and EncodeUtility#18264
SelaseKay merged 6 commits into
mainfrom
firestore_18233

Conversation

@SelaseKay
Copy link
Copy Markdown
Contributor

@SelaseKay SelaseKay commented May 8, 2026

Description

Problem

On web, startAfter / startAfterDocument could return the same document again when the result set had only one matching row, causing infinite pagination loops.

Cause

Cursor values for web queries are built from encoded field values. EncodeUtility.valueEncode converted Dart Timestamp to DateTime via toDate(), which loses sub-millisecond precision when passed to the Firestore JS SDK. The cursor tuple could then sort before the real document position in the index, so the next page still included that document.

Fix

Encode Dart Timestamp as the Firestore JS Timestamp (seconds + nanoseconds) in EncodeUtility.valueEncode, matching how the SDK compares stored timestamps.

Related Issues

Fixes #18233

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@SelaseKay SelaseKay changed the title fix(firestore): update Timestamp handling in jsify and EncodeUtility fix(firestore, web): update Timestamp handling in jsify and EncodeUtility May 11, 2026
@SelaseKay SelaseKay marked this pull request as ready for review May 11, 2026 14:56
@SelaseKay SelaseKay merged commit 9783a44 into main May 11, 2026
33 of 35 checks passed
@SelaseKay SelaseKay deleted the firestore_18233 branch May 11, 2026 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[cloud_firestore]: startAfterDocument does not correctly return an empty query snapshot

3 participants