ci: update swift-integration tests to work on main#18083
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. |
Description
On pushes to
main,PR_HEAD_REPOis empty (no PR context), so the repo slug comparisonheadRepo != baseRepoevaluates to"" != "firebase/flutterfire"which istrue, picking the empty string as the repo slug. This produces an invalid SPM package URL (https://github.com/) which SPM resolves as a package namedgithub.cominstead offlutterfire, breaking all plugin target dependencies.The fix adds null/empty checks before comparing
headRepowithbaseRepo.Related Issues
swift-integrationCI job failing onmainbranch pushesChecklist
///).melos run analyze) does not report any problems on my PR.Breaking Change