fix(messaging): macos incorrect parsing of notification response …#17231
Open
steffenhaak wants to merge 5 commits intofirebase:mainfrom
Open
fix(messaging): macos incorrect parsing of notification response …#17231steffenhaak wants to merge 5 commits intofirebase:mainfrom
steffenhaak wants to merge 5 commits intofirebase:mainfrom
Conversation
…inishLaunchingNotification
steffenhaak
changed the title
MichaelVerdon
requested changes
Apr 11, 2025
| // Setup UIApplicationDelegate. | ||
| #if TARGET_OS_OSX | ||
| NSDictionary *remoteNotification = notification.userInfo[NSApplicationLaunchUserNotificationKey]; | ||
| UNNotificationResponse *notificationResponse = notification.userInfo[NSApplicationLaunchUserNotificationKey]; |
Contributor
There was a problem hiding this comment.
Hey there, I am sorry I did not see this sooner. It looks alright to me. Can I get you to fix formatting issues that occured on CI? Should be very quick.
Author
There was a problem hiding this comment.
Hi @MichaelVerdon , I am very sorry, I unfortunately lost sight of your message. I just ran clang-format (see latest commit), so the tests now should pass. Can you approve another test run?
Contributor
There was a problem hiding this comment.
Hi there thanks for the ping @steffenhaak I will be checking this out properly
There was a problem hiding this comment.
Hi @MichaelVerdon, did you ever get a chance to re-review this fix? It has been a sore spot for one of my applications for a long time unfortunately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…in application_onDidFinishLaunchingNotification
Description
See bug report in related issue.
Related Issues
#17230
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?