Skip to content

fix(fcm): add check for scene delegates in deep links#15987

Open
daymxn wants to merge 4 commits intomainfrom
dlr/messaging-scene-migration
Open

fix(fcm): add check for scene delegates in deep links#15987
daymxn wants to merge 4 commits intomainfrom
dlr/messaging-scene-migration

Conversation

@daymxn
Copy link
Copy Markdown
Member

@daymxn daymxn commented Mar 26, 2026

Per b/496594918,

This fixes an issue where deep links in FCM (when using automatic routing) would not properly propagate to the app's corresponding delegate, if the developer was using a scene delegate instead of an app delegate.

Now, the code first checks for any scene delegates that can handle the request, and falls back to the application delegate if one wasn't found.

@daymxn daymxn requested a review from ncooke3 March 26, 2026 17:36
@daymxn daymxn self-assigned this Mar 26, 2026
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Copy link
Copy Markdown
Contributor

@leojaygoogle leojaygoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@daymxn daymxn added this to the Firebase 13 milestone Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants