Refactor: Make defineString generic for better type-safety

[keeganpotgieter]

Description

The defineString function does not narrow the type when adding input.select.options. This means we have to typecast in certain situations, even though we know what the types should be.

Code sample

const environmentParam = params.defineString("ENVIRONMENT", {
      default: "production", // This will now error out if it does not match one of the options
      input: {
        select: {
          options: [
            { label: "Production", value: "production" },
            { label: "Staging", value: "staging" },
            { label: "Development", value: "development" },
          ],
        },
      },
});

const environment = environmentParam.value();
// ^? "production" | "staging" | "development"

Limitations

• If defaultValue is provided with no options the value is still wide, rather than loose autocomplete

[cabljac]

/gemini

[gemini-code-assist]

Code Review

This pull request introduces a great improvement by making defineString generic, which enhances type-safety when using select options. The use of NoInfer<T> is a good way to control type inference for the default value. However, I've found a critical issue in the implementation of StringParam.runtimeValue that could lead to runtime errors. My review includes a suggestion to fix this. Once that's addressed, this will be a solid refactoring.

[gemini-code-assist]

It looks like you tried to invoke a command, but you didn't specify which one. Please use /gemini <command> or @gemini-code-assist <command> to specify a command. For a list of available commands, you can use /gemini help.

[cabljac]

Hi! Thanks for the contribution!

I think we'd probably want to add some test cases here -

1. Test type narrowing works using select options - perhaps just type assertions?
2. Test backward compatibility without select options
3. Test runtime behavior when env var contains an invalid value?
4. Test edge case when env var is undefined (see comment on the relevant code)