Change it so that the header files are directly included#1865
Open
AustinBenoit wants to merge 2 commits into
Open
Change it so that the header files are directly included#1865AustinBenoit wants to merge 2 commits into
AustinBenoit wants to merge 2 commits into
Conversation
Remove the cmake injection and just include the header files as needed
faa6c96 to
0aa2751
Compare
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the automatic global inclusion of headers like assert.h, string.h, and stdint.h from CMakeLists.txt files across various modules, replacing them with explicit #include statements in the individual source and header files. The reviewer feedback recommends two main improvements: first, reordering includes so that companion headers are always included first (consistent with the Google C++ Style Guide); second, preferring C++ standard library headers (such as , , and ) over their C-style counterparts (like <assert.h>, <stdint.h>, and <string.h>) to ensure consistency and proper namespace scoping.
0461c0e to
d644d53
Compare
d644d53 to
089add8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Change it so that the header files are directly included
Testing
Run all integration tests in github
Type of Change
Place an
xthe applicable box:Notes
Release Notessection ofrelease_build_files/readme.md.