Change nightly status script to not depend on time#1863
Conversation
There was a problem hiding this comment.
Code Review
This pull request modifies the build status reporting script to select either the earliest or latest scheduled test run for a given day, removing the previous specific hour constraints. The reviewer identified critical issues in this new logic, including a logical bug in the date comparison (since comparing .date() objects on the same day will always evaluate to equal), unreachable code for non-Firestore runs, and suboptimal filtering order. A code suggestion was provided to resolve these issues by reordering the filters and comparing full datetime objects.
❌ Integration test FAILEDRequested by @a-maurice on commit 9ae22e9
Add flaky tests to go/fpl-cpp-flake-tracker |
Description
The nightly report routinely fails to find source tests because it is relying on the time, which is inconsistent. Instead, check if the run was invoked via a schedule, and the determine if it is Firestore by using the time.
Testing
Running it locally.
Type of Change
Place an
xthe applicable box:Notes
Release Notessection ofrelease_build_files/readme.md.