dataconnect(chore): CoroutineUtils.kt added with function createSupervisorCoroutineScope()#8133
Conversation
…()` and code modified to use it, replacing bespoke scope creation logic
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
|
/gemini review |
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new utility function, createSupervisorCoroutineScope, to standardize the creation of coroutine scopes with supervisor jobs and exception handlers across several components, including DataConnectCredentialsTokenManager, FirebaseDataConnectImpl, LiveQuery, and DataConnectCacheDatabase. A logic error was identified in the CoroutineUtils implementation where CoroutineName is not unconditionally replaced as documented, which could cause child scopes to inherit parent names and complicate debugging.
…outineScope(), and fix the CoroutineName bug. The "CoroutineName Bug" was identified by gemini code assist: The implementation of CoroutineName assignment does not match the docstring and introduces a regression in behavior. The docstring states that the CoroutineName will be unconditionally replaced, but the current implementation only sets it if it is missing from the context. This causes child scopes (like the one in DataConnectCredentialsTokenManager) to inherit the parent's name instead of using their own instanceId, which can make debugging and log analysis more difficult.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces a centralized utility, createSupervisorCoroutineScope, to standardize the creation of coroutine scopes with supervisor jobs and consistent exception handling across the codebase. This utility is integrated into several classes, reducing boilerplate and ensuring uniform logging of uncaught exceptions. Review feedback highlights a slight regression in logging detail where the exception string is no longer explicitly appended to the log message, and notes the removal of a specific error code in FirebaseDataConnectImpl that might be useful for debugging.
2 participants
No description provided.