[AI] Use Ktor's HttpRequestTimeoutException for timeout handling#7966
[AI] Use Ktor's HttpRequestTimeoutException for timeout handling#7966
Conversation
Updated the exception handling logic to catch `HttpRequestTimeoutException` from the Ktor HTTP client for request timeouts. This replaces the previous reliance on `TimeoutCancellationException`, which comes from the coroutine rather than the network layer. The timeout test in `APIControllerTests` is temporarily disabled due to missing Ktor timeout testing support.
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
2 participants
Updated the exception handling logic to catch
HttpRequestTimeoutExceptionfrom the Ktor HTTP client for request timeouts. This replaces the previous reliance onTimeoutCancellationException, which comes from the coroutine rather than the network layer.The timeout test in
APIControllerTestsis temporarily disabled due to missing Ktor timeout testing support.