Skip to content

Gradle task injectCrashlyticsBuildIds fails when processing unparseable ELFs #7965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrober merged 4 commits into from
Mar 25, 2026
Merged

Gradle task injectCrashlyticsBuildIds fails when processing unparseable ELFs #7965

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
855a7ce
NIT: Extending catch clause to prevent build breaking.
OOS93 Mar 24, 2026
2a9a413
Merge remote-tracking branch 'origin/build_info_collector_nit' into b…
OOS93 Mar 25, 2026
5c7c2f3
NIT: Avoiding chained exceptions.
OOS93 Mar 25, 2026
359370b
Changelog update.
OOS93 Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ...c/main/java/com/google/firebase/crashlytics/buildtools/buildids/BuildIdInfoCollector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
import com.google.firebase.crashlytics.buildtools.ndk.internal.elf.ElfSymbol;
import com.google.firebase.crashlytics.buildtools.utils.FileUtils;
import java.io.File;
import java.io.IOException;
import java.util.ArrayList;
import java.util.List;
import java.util.Optional;
Expand All @@ -47,7 +46,7 @@ private Optional<BuildIdInfo> getBuildIdInfo(File file) {
BuildIdInfoContentHandler contentHandler = new BuildIdInfoContentHandler(file.getName());
try {
ElfDataParser.parse(file, contentHandler, false);
} catch (IOException | NegativeArraySizeException | ArithmeticException ex) {
} catch (Exception ex) {
// TODO(b/289053263): Make build tools support Go binaries smoother.
// Ignore any file that doesn't parse, or has unexpected opcodeBase, to avoid breaking builds.
getLogger().logD("Unable to parse binary: " + file.getPath() + " - " + ex.getMessage());
Expand Down
1 change: 1 addition & 0 deletions firebase-crashlytics-gradle/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
### Unreleased

- [changed] Improved efficiency when extracting breakpad binary files.
- [fixed] Avoid build breaks when handling unsupported native libraries for injectCrashlyticsBuildIds task [#7780]

### Crashlytics Gradle plugin version 3.0.6

Expand Down
Loading