Skip to content

feat: Add timestamp expressions#7955

Open
yvonnep165 wants to merge 5 commits intomainfrom
yvonne/timestamp-expressions
Open

feat: Add timestamp expressions#7955
yvonnep165 wants to merge 5 commits intomainfrom
yvonne/timestamp-expressions

Conversation

@yvonnep165
Copy link
Contributor

@yvonnep165 yvonnep165 commented Mar 23, 2026

Add new timestamp expressions timestamp_diff and timestamp_extract and integration tests for the expressions

The expression timestamp_trunc already existed in the repo with integration tests.
Add methods for timestampTruncWithTimezone to avoid signature collision.
Add methods to allow timezone as parameter in chained expressions.
Amend the tests for the timestamp_trunc expression

Ported from firebase/firebase-js-sdk#9728

@gemini-code-assist
Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@yvonnep165 yvonnep165 requested review from dlarocque and milaGGL March 23, 2026 17:08
@github-actions
Copy link
Contributor

github-actions bot commented Mar 23, 2026

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@yvonnep165
Copy link
Contributor Author

@rlazo Just for a headsup, we got a Metalava SemVer breaking change alert for timestampTruncate expression porting. But since we're still in public preview, it shouldn't be a problem.

@rlazo
Copy link
Contributor

rlazo commented Mar 24, 2026

@rlazo Just for a headsup, we got a Metalava SemVer breaking change alert for timestampTruncate expression porting. But since we're still in public preview, it shouldn't be a problem.

SGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants