Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -723,8 +723,8 @@ class UploadDistributionTaskTest {
// out.
// Also remember to update the latest AGP/gradle versions in BeePlusGradleProject.java.
// firebase-appdistribution-gradle/src/prodTest/java/com/google/firebase/appdistribution/gradle/BeePlusGradleProject.java#L59-L60
private const val LATEST_GRADLE_VERSION = "9.4.0"
private const val LATEST_AGP_VERSION = "9.2.0-alpha02"
private const val LATEST_GRADLE_VERSION = "9.5.0-milestone-5"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

traditionally, we've never tested "milestone" versions of Gradle itself. Only release candidates and regular versions.

I think it makes sense to maintain that. To accomplish this, we will probably need to filter AGP versions to only "rc", too - and ignore any "alpha" versions.

What do you think?

private const val LATEST_AGP_VERSION = "9.2.0-alpha04"
private const val LATEST_GOOGLE_SERVICES_VERSION = "4.4.4"
// For tests against Gradle 9, we get the error:
// "In order to compile Java 9+ source, please set compileSdkVersion to 30 or above"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,8 @@ private static String getRequiredSystemProperty(String propertyName) {
static final String PACKAGE_NAME = "com.firebase.appdistribution.prober";
// Also remember to update the latest AGP/gradle versions in UploadDistributionTaskTest.kt
// firebase-appdistribution-gradle/src/integrationTest/java/com/google/firebase/appdistribution/gradle/UploadDistributionTaskTest.kt#L724-L726
static final String LATEST_AGP_VERSION = "9.2.0-alpha02";
static final String LATEST_GRADLE_VERSION = "9.4.0";
static final String LATEST_AGP_VERSION = "9.2.0-alpha04";
static final String LATEST_GRADLE_VERSION = "9.5.0-milestone-5";
// The project number for App Distro Probes. We need to use this project
// because this is the one that's actually linked to play for BeePlus,
// which is required for AAB uploads.
Expand Down
Loading