[Firestore] Add support for regexFind and regexFindAll#7669
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. |
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces support for regexFind and regexFindAll expressions in the Firestore Pipelines API, along with corresponding test cases and internal evaluation logic. The changes are well-structured, adding new API methods, registering them, implementing their evaluation, and providing comprehensive tests. Overall, the new functionality is a valuable addition.
firebase-firestore/src/main/java/com/google/firebase/firestore/pipeline/evaluation/Strings.kt
Outdated
Show resolved
Hide resolved
firebase-firestore/src/main/java/com/google/firebase/firestore/pipeline/evaluation/Strings.kt
Outdated
Show resolved
Hide resolved
firebase-firestore/src/main/java/com/google/firebase/firestore/util/RegexUtils.kt
Outdated
Show resolved
Hide resolved
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces support for regexFind and regexFindAll expressions in the Firestore Pipelines API. The implementation includes new API methods, evaluation logic, and comprehensive unit and instrumented tests. The code is well-structured, with clear separation of concerns, and includes good error handling for invalid regular expressions and unsupported capturing group scenarios. The Javadoc for the new API methods is thorough and provides helpful examples.
firebase-firestore/src/main/java/com/google/firebase/firestore/util/RegexUtils.kt
Outdated
Show resolved
Hide resolved
firebase-firestore/src/main/java/com/google/firebase/firestore/pipeline/evaluation/Strings.kt
Show resolved
Hide resolved
firebase-firestore/src/main/java/com/google/firebase/firestore/pipeline/evaluation/Strings.kt
Show resolved
Hide resolved
…/util/RegexUtils.kt Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
firebase-firestore/src/androidTest/java/com/google/firebase/firestore/PipelineTest.java
Outdated
Show resolved
Hide resolved
2 participants
Adds support for
regexFindandregexFindAllexpressions in the Pipeline and RealtimePipeline API.