Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. |
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
Generated by 🚫 Danger |
|
The public api surface has changed for the subproject firebase-firestore: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
wu-hui
force-pushed
the
push-mzrnxxpnzsmq
branch
from
e6f103f to
3567cf8
Compare
|
The public api surface has changed for the subproject firebase-firestore: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
wu-hui
force-pushed
the
push-mzrnxxpnzsmq
branch
from
3567cf8 to
fa82582
Compare
|
Please ignore the semver check failure, we are removing some Public Preview APIs that were exposed by accident. |
| * more efficient implementations are possible. | ||
| */ | ||
| class InternalOptions internal constructor(private val options: ImmutableMap<String, Value>) { | ||
| internal class InternalOptions |
There was a problem hiding this comment.
Heads up, this would be a breaking change
There was a problem hiding this comment.
Yep, this is intentional. We accidentally exposed them during the initial release. Note these are public preview APIs, so I think we can do it?
If you agree, can you also advise on how to bypass SemVer check? @rlazo
There was a problem hiding this comment.
Is it documented that they are public preview? From the documentation in this file is not clear.
There was a problem hiding this comment.
Yeah, I think this is another oversight.
There was a problem hiding this comment.
Do you prefer to do this during a breaking change? I am OK with this. We might actually be breaking somebody by then. We wanted to do earlier so now nobody is actually broke by this, because it is still new.
Anyways, it will be the core team's call.
wu-hui
force-pushed
the
push-mzrnxxpnzsmq
branch
from
00f85b4 to
35d425d
Compare
3 participants
No description provided.