feat(fcm): Enable fid and deprecate token for Send API#765
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces support for Firebase Installation IDs (FIDs) across the messaging service, updating the Message and MulticastMessage structs, deprecating the older token fields, and adapting validation and batch processing logic. The review feedback suggests standardizing the deprecation comments to follow Go conventions and enhancing the TestSendEachForMulticastMixed test to perform more robust assertions using an existing helper function.
…MulticastMixed and change deprecation comment format
yvonnep165
force-pushed
the
yp-add-fid-arg
branch
from
0caa3a0 to
70750cb
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces support for Firebase Installation IDs (FIDs) in the FCM messaging client. It adds the Fid field to the Message struct and the Fids field to the MulticastMessage struct, deprecating the older Token and Tokens fields respectively. The validation logic, unit tests, and integration tests have been updated to support and validate FIDs alongside tokens, topics, and conditions. There are no review comments, so I have no feedback to provide.
2 participants
This change deprecates
Token(inMessage) andTokens(inMulticastMessage) as message targets, transitioning support toFid(Firebase Installation ID) andFidsas the primary targets instead.