Skip to content

feat: upgrade all packages min SDK to Dart 3.5#616

Open
kevmoo wants to merge 3 commits intomainfrom
bump_deps
Open

feat: upgrade all packages min SDK to Dart 3.5#616
kevmoo wants to merge 3 commits intomainfrom
bump_deps

Conversation

@kevmoo
Copy link
Collaborator

@kevmoo kevmoo commented Mar 25, 2026

Move to workspaces

@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly updates the project's foundation by raising the minimum Dart SDK version to 3.5 across all packages. It streamlines the linting process by centralizing analysis options and upgrading the flutter_lints package, leading to cleaner code and better adherence to best practices. Additionally, it enhances the robustness of firebase_ui_auth components by introducing context.mounted checks, preventing common Flutter errors related to widget lifecycle.

Highlights

  • Minimum SDK Upgrade: All packages have been upgraded to support a minimum Dart SDK version of 3.5, aligning with newer language features and platform capabilities.
  • Linting Configuration Centralization and Update: Individual analysis_options.yaml files across various packages and examples have been removed, indicating a move towards a centralized linting configuration. The flutter_lints dependency has been updated to ^6.0.0 across all pubspec.yaml files, and the main analysis_options.yaml now includes unnecessary_ignore.
  • Flutter Context Safety: Added context.mounted checks in several firebase_ui_auth widgets (FirebaseUIAuth, _MFAToggleState, _DeleteAccountButtonState, _EditableUserDisplayNameState) to prevent accessing BuildContext after the widget has been disposed, improving application stability.
  • Code Cleanup and Lint Rule Compliance: Numerous // ignore: comments (e.g., do_not_use_environment, lines_longer_than_80_chars, avoid_classes_with_only_static_members, deprecated_member_use, prefer_const_constructors, library_private_types_in_public_api, subtype_of_sealed_class, avoid_implementing_value_types, join_return_with_assignment) have been removed, suggesting improved code quality and adherence to updated lint rules.
  • Workspace Management Dependencies: New development dependencies (path, yaml, yaml_edit) were added to the root pubspec.yaml, likely to support workspace management and automated dependency updates or analysis option synchronization.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request primarily updates the flutter_lints dependency to version ^6.0.0 across all packages and examples. This upgrade led to several code hygiene improvements, including the removal of various // ignore: directives that are no longer needed or are now handled by the linter. Crucially, if (!mounted) return; checks were added in several UI-related files to ensure BuildContext is not used after a widget has been disposed, enhancing the robustness of the Flutter widgets. Additionally, minor type annotation changes were made, and new yaml related dev dependencies were added to the root pubspec.yaml. I have no feedback to provide.

@kevmoo kevmoo requested a review from russellwheatley March 25, 2026 18:42
@kevmoo kevmoo mentioned this pull request Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant