feat: upgrade all packages min SDK to Dart 3.5#615
feat: upgrade all packages min SDK to Dart 3.5#615russellwheatley merged 8 commits intofirebase:mainfrom
Conversation
Move to workspaces
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly updates the project's dependency management and Dart SDK compatibility. It transitions the entire repository to utilize Dart Workspaces, centralizing package resolution and simplifying local development. Concurrently, it elevates the minimum required Dart SDK to 3.5, enabling the adoption of newer language features and ensuring compatibility with the latest Dart ecosystem standards. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the project's dependency management and Dart SDK compatibility. It upgrades the Dart SDK requirement to ^3.5.0 across all packages and examples, and adopts the new resolution: workspace feature in pubspec.yaml files, along with defining the monorepo structure in the root pubspec.yaml. This change replaces the previous melos_managed_dependency_overrides mechanism. Additionally, it updates the melos dependency version and includes minor null-safety and Dart 3.0 pattern matching syntax improvements in some Dart files. There is no feedback to provide.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request primarily migrates the project's Melos configuration from a dedicated melos.yaml file to the root pubspec.yaml using the new workspace feature. It updates the Dart SDK constraint across all packages and examples to ^3.5.0 and introduces resolution: workspace in their pubspec.yaml files. Additionally, it includes minor null-safety adjustments in several Dart files (removing null assertion operators and refactoring a switch statement to if-else), adds // ignore: deprecated_member_use comments for deprecated Flutter properties, and updates the FirebaseFirestore pod version in the iOS and macOS Podfiles. There is no feedback to provide from the review comments.
Move to workspaces