Skip to content

feat: upgrade all packages min SDK to Dart 3.5#615

Merged
russellwheatley merged 8 commits intofirebase:mainfrom
kevmoo:workspace_maybe
Mar 25, 2026
Merged

feat: upgrade all packages min SDK to Dart 3.5#615
russellwheatley merged 8 commits intofirebase:mainfrom
kevmoo:workspace_maybe

Conversation

@kevmoo
Copy link
Collaborator

@kevmoo kevmoo commented Mar 24, 2026

Move to workspaces

@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly updates the project's dependency management and Dart SDK compatibility. It transitions the entire repository to utilize Dart Workspaces, centralizing package resolution and simplifying local development. Concurrently, it elevates the minimum required Dart SDK to 3.5, enabling the adoption of newer language features and ensuring compatibility with the latest Dart ecosystem standards.

Highlights

  • Dart SDK Upgrade: The minimum Dart SDK version has been upgraded to 3.5.0 across all packages and examples within the repository, leveraging new language features.
  • Dart Workspaces Adoption: The project has been migrated to use Dart Workspaces for improved dependency management. This involves adding resolution: workspace to individual pubspec.yaml files and defining the workspace structure in the root pubspec.yaml.
  • Melos Configuration Update: The melos.yaml configuration has been streamlined by removing the bootstrap section, and the melos dependency in the root pubspec.yaml has been updated to ^6.3.0.
  • Code Modernization: Dart 3.5 language features have been adopted, specifically removing redundant null assertion operators (!) and updating switch statements to use pattern matching syntax (_) where applicable.
  • Dependency Overrides Removal: The pubspec_overrides.yaml file in packages/firebase_ui_localizations/example has been removed, as its functionality is now handled by Dart Workspaces.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the project's dependency management and Dart SDK compatibility. It upgrades the Dart SDK requirement to ^3.5.0 across all packages and examples, and adopts the new resolution: workspace feature in pubspec.yaml files, along with defining the monorepo structure in the root pubspec.yaml. This change replaces the previous melos_managed_dependency_overrides mechanism. Additionally, it updates the melos dependency version and includes minor null-safety and Dart 3.0 pattern matching syntax improvements in some Dart files. There is no feedback to provide.

@kevmoo
Copy link
Collaborator Author

kevmoo commented Mar 25, 2026

/gemini review

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request primarily migrates the project's Melos configuration from a dedicated melos.yaml file to the root pubspec.yaml using the new workspace feature. It updates the Dart SDK constraint across all packages and examples to ^3.5.0 and introduces resolution: workspace in their pubspec.yaml files. Additionally, it includes minor null-safety adjustments in several Dart files (removing null assertion operators and refactoring a switch statement to if-else), adds // ignore: deprecated_member_use comments for deprecated Flutter properties, and updates the FirebaseFirestore pod version in the iOS and macOS Podfiles. There is no feedback to provide from the review comments.

@russellwheatley russellwheatley merged commit aefa711 into firebase:main Mar 25, 2026
21 checks passed
@kevmoo kevmoo deleted the workspace_maybe branch March 25, 2026 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants