feat(proxy): expose proxy middleware utilities (#1599)#1600
Open
rajeevr-g wants to merge 4 commits into
Open
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1600 +/- ##
==========================================
- Coverage 90.10% 85.38% -4.72%
==========================================
Files 69 83 +14
Lines 5657 7878 +2221
Branches 990 1312 +322
==========================================
+ Hits 5097 6727 +1630
- Misses 541 1123 +582
- Partials 19 28 +9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Hi @kriswest , could you please look into this PR and please approve if everything looks good? |
kriswest
approved these changes
Jun 16, 2026
kriswest
left a comment
kriswest
left a comment
Contributor
There was a problem hiding this comment.
Could be simpler to export * from routes, otherwise no objectsions.
Comment on lines
+23
to
+31
| export { | ||
| getRouter, | ||
| proxyFilter, | ||
| extractRawBody, | ||
| validGitRequest, | ||
| buildUpstreamProxyAgent, | ||
| hostMatchesNoProxy, | ||
| getOrCreateProxyAgent, | ||
| } from './routes'; |
Contributor
There was a problem hiding this comment.
You could probably export * from routes as you are only missing handleMessage and handleRefsErrorMessage from the full list of routes exports.
Contributor
Author
|
Hi @kriswest , I am done with changes, could you please check? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Exposes additional proxy middleware utilities through the @finos/git-proxy/proxy package exports to enable advanced integration and custom proxy composition.
General changes:
Added proxy middleware utilities to public ./proxy exports
Exposed request filtering and validation utilities for external use
Enabled reuse of internal proxy composition logic without deep imports
Related Issue
Resolves #1599
Checklist
General
Documentation
Configuration
config.schema.json) was modified:npm run generate-config-types)npm run gen-schema-doc)Tests
npm test)npm run lintandnpm run format:check)npm run check-types)