chore(deps): bump vitest to v4 and fix tests#1564
Open
jescalada wants to merge 8 commits into
Open
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Dependency ReviewThe following issues were found:
License Issuespackage-lock.json
OpenSSF ScorecardScorecard details
Scanned Files
|
Prevents EADDRINUSE error on parallel test execution, drastically speeds up test execution
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1564 +/- ##
==========================================
- Coverage 90.68% 89.06% -1.62%
==========================================
Files 69 65 -4
Lines 5741 3467 -2274
Branches 989 565 -424
==========================================
- Hits 5206 3088 -2118
+ Misses 517 234 -283
- Partials 18 145 +127 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
The dependency review is complaining on This is a known issue with Dependency Review not falling back to the GH license fetch API when the dependency graph API doesn't fetch as intended: actions/dependency-review-action#704 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bumps Vitest to v4 and fixes resulting failing tests from syntax changes.
Despite adding the
uiPortmocks to fix someEADDRINUSEerrors when running tests in parallel, I decided to keep the sequential tests (by disabling thefileParallelismoption, formerlypoolOptions.forks.singleFork).This is because a few tests still fail when running
npm run test-shuffle, and the MongoDB integration tests also fail on the CI when enabling parallelism. I made an issue to track this so we can benefit from parallel test execution speedup: #1565Checklist
General
Tests
npm test)npm run lintandnpm run format:check)npm run check-types)