fix: update @types/express-serve-static-core to 5.1.1 and fix typing of Request params#1409
Open
fix: update @types/express-serve-static-core to 5.1.1 and fix typing of Request params#1409
Conversation
…of Request params
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1409 +/- ##
==========================================
+ Coverage 81.37% 81.39% +0.02%
==========================================
Files 67 67
Lines 4735 4741 +6
Branches 819 819
==========================================
+ Hits 3853 3859 +6
Misses 867 867
Partials 15 15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While testing I noticed that theres an update to express-serve-static-core 5.06 -> 5.1.1 that contains a correction to express's Request type - which looks breaking (but the change actually happened in a major release, the type was just wrong).
At present
Request.paramshas typeRecord<string, string>but its being 'corrected' toRecord<string, string | string []>(as path params in express 5 can have multiple components and provide an array of values in those cases).To prevent type issues that break the build, we need to strongly type Request, which I've done in this PR. @jescalada this may have a bearing on #1323 where you are adding in the Request type in may places (and may also need to add the types for the params object there if accessing its properties).