Skip to content

fix: update @types/express-serve-static-core to 5.1.1 and fix typing of Request params#1409

Open
kriswest wants to merge 1 commit intomainfrom
update-express-serve-static-core
Open

fix: update @types/express-serve-static-core to 5.1.1 and fix typing of Request params#1409
kriswest wants to merge 1 commit intomainfrom
update-express-serve-static-core

Conversation

@kriswest
Copy link
Contributor

While testing I noticed that theres an update to express-serve-static-core 5.06 -> 5.1.1 that contains a correction to express's Request type - which looks breaking (but the change actually happened in a major release, the type was just wrong).

At present Request.params has type Record<string, string> but its being 'corrected' to Record<string, string | string []> (as path params in express 5 can have multiple components and provide an array of values in those cases).

To prevent type issues that break the build, we need to strongly type Request, which I've done in this PR. @jescalada this may have a bearing on #1323 where you are adding in the Request type in may places (and may also need to add the types for the params object there if accessing its properties).

@kriswest kriswest requested a review from a team as a code owner February 19, 2026 19:53
@netlify
Copy link

netlify bot commented Feb 19, 2026

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit 1b03ca3
🔍 Latest deploy log https://app.netlify.com/projects/endearing-brigadeiros-63f9d0/deploys/69976a41dfd02a0008b68fec

@github-actions github-actions bot added the fix label Feb 19, 2026
@github-actions
Copy link

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

@codecov
Copy link

codecov bot commented Feb 19, 2026

Codecov Report

❌ Patch coverage is 65.95745% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.39%. Comparing base (468bd12) to head (1b03ca3).

Files with missing lines Patch % Lines
src/service/routes/repo.ts 61.90% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1409      +/-   ##
==========================================
+ Coverage   81.37%   81.39%   +0.02%     
==========================================
  Files          67       67              
  Lines        4735     4741       +6     
  Branches      819      819              
==========================================
+ Hits         3853     3859       +6     
  Misses        867      867              
  Partials       15       15              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments