Enforce OSGI Import-Package of guava libraries to use version >=16 && < 19, to allow using with latest Guava #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… < 19, to allow using with latest Guava
Owner
|
Ow. Well, you seem to know a lot more than I about OSGi... I added the plugin to satisfy the needs of (I don't even remember who) and it seems you understand it a LOT more than I do... I don't have the time to look into it right now; I'll keep you informed. The next bits of information however might turn out to be questions which I'd like an answer to :p Thanks for this PR (and the other one as well). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the latest build of the library in an OSGI environment, any apps which uses Guava 18.0 will not be able to use jackson-coreutils (or jackson-patch; see separate pull request), since the Import-Package section of jackson-coreutils specifies com.google.common.base version >=16.0 & < 17.0 (as automatically created by the osgi plugin).
This patch specifically overrides the version requirements for the Guava imports, allowing version >=16 & < 19. This will be a problem when version 19 is released, but the alternative would be to have no upper version at all, which may also cause problems in the future.
Not sure what is best, keep it open and be aware that future versions might deprecate some calls? Guava has a pretty strict deprecation policy (kept 2 years after @deprecated) so might be quite safe to do.
(And no, I'm probably not the right person to take maintainership, I've just started using json-patch. Thanks for a good library!)