Boundary condition handling #1044
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## fenicsx #1044 +/- ##
===========================================
- Coverage 94.87% 94.87% -0.01%
===========================================
Files 44 44
Lines 3085 3100 +15
===========================================
+ Hits 2927 2941 +14
- Misses 158 159 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jhdark
added
bug
Collaborator
RemDelaporteMathurin
left a comment
RemDelaporteMathurin
left a comment
There was a problem hiding this comment.
easy enough fix
Comment on lines
304
to
313
| @property | ||
| def all_bcs(self): | ||
| """Returns all boundary conditions, including fluxes from surface reactions""" | ||
| all_boundary_conditions = [] | ||
| for bc in self.boundary_conditions: | ||
| if isinstance(bc, boundary_conditions.SurfaceReactionBC): | ||
| all_boundary_conditions.extend(bc.flux_bcs) | ||
| else: | ||
| all_boundary_conditions.append(bc) | ||
| return all_boundary_conditions |
Collaborator
There was a problem hiding this comment.
Reflecting on it now, the problem I have with having this as a property is that now the problem class has 2 attributes that are similar: self.boundary_conditions and self.all_bcs...
Collaborator
Author
There was a problem hiding this comment.
Should we make all_bcs hidden instead? just _all_bcs?
| spe.test_function = sub_test_functions[idx] | ||
|
|
||
| def define_boundary_conditions(self): | ||
| # @jhdark this all_bcs could be a property |
RemDelaporteMathurin
approved these changes
Nov 21, 2025
RemDelaporteMathurin
merged commit 19a899f
into
festim-dev:fenicsx
10 of 11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fix for #1043
With these changes, a new property is added to the
HydrogenTransportProblemclass:all_bcs. This was something that was done during thedefine_boundary_conditionsconditions but now has been removed.Additionally, to fix the bug in #1043, a new
define_boundary_conditionshas been added toHydrogenTransportProblemDiscontinuousas thecreate_value_fenicsfunction was failing previously, as the solution was never passed to the species. This is more of a light fix in that sense, and the class could do with an overhaul to handle that better. What do you think @RemDelaporteMathurin ?Types of changes
What types of changes does your code introduce to FESTIM?
Checklist
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...