-
Notifications
You must be signed in to change notification settings - Fork 10
Upgrading to Jupyter 2 #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: festim2
Are you sure you want to change the base?
Conversation
Co-authored-by: Matt Fisher <3608264+mfisher87@users.noreply.github.com>
Should it be |
|
Now it looks like your conda environment isn't being installed 😖 I'm not 100% sure why. It looks like you did everything right. Personally, I struggle to remember the implicit behaviors in the RTD build environment so I often fully override the build process like this: https://github.com/geojupyter/geojupyter.org/blob/main/.readthedocs.yaml This is more explicit and IMO more understandable. |
.readthedocs.yml
Outdated
| - conda env create --name festim-workshop-jupyter2 --file environment.yml | ||
| # - cd book | ||
| # - conda run -n festim-workshop-jupyter2 python -m jupyter book start | ||
| - conda run -n festim-workshop-jupyter2 bash -c "cd book && python -m jupyter book build --html" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - conda run -n festim-workshop-jupyter2 bash -c "cd book && python -m jupyter book build --html" | |
| - conda run -n festim-workshop-jupyter2 bash -c "cd book && HOST="127.0.0.1" python -m jupyter book build --html" |
This should get you around the ECONNREFUSED errors. Let me know if this doesn't help.
.readthedocs.yml
Outdated
| - ls | ||
| - mkdir -p $READTHEDOCS_OUTPUT/html | ||
| - ls | ||
| - cp -r _build/html/* $READTHEDOCS_OUTPUT/html/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - cp -r _build/html/* $READTHEDOCS_OUTPUT/html/ | |
| - cp -r book/_build/html/* $READTHEDOCS_OUTPUT/html/ |
Adding this back in since cd book is now commented out :)
book/myst.yml
Outdated
| logo: images/logo_light.png | ||
| logo_dark: images/logo_dark.svg | ||
| folders: true | ||
| template: book-theme |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| template: book-theme | |
| template: "https://github.com/myst-templates/book-theme/archive/de4c1e9c09c6cd12fc529c1f22e8abf8e7f35381.zip" |
This should hopefully resolve the ECONNREFUSED error! You should probably revert this after the next JB2 release.
|
Yay! |
|
Sorry I'm viewing this on my phone but it seems the pyvista plots are not rendered properly? Great that we got this far! |
|
Hmm yeah it doesn't look like they're loading, I can look into it |
|
@ck768 @mfisher87 it seems like myst cannot render pyvista plots jupyter-book/mystmd#449
Although it seems to be possible here: pyvista/pyvista#6189 |

testing out the upgrade to Jupyter 2